Various fluid recipes are incorrect

[Maelstromeous]

Getting reports of various fluid recipes being incorrect. Need to do a full comparison of them in game and see the issues.

[Maelstromeous]

Provisional fix in https://github.com/Maelstromeous/satisfactory-factories/commit/63c083b2c91be73066bf3e700a90f464cd4254f5, needs fix confirm

[Maelstromeous]

Can confirm there's still bugs:

Requests for water is too high.

[Maelstromeous]

Game data is correct, it's a calculation issue.

        {
            "id": "AluminaSolution",
            "displayName": "Alumina Solution",
            "ingredients": [
                {
                    "part": "OreBauxite",
                    "amount": 12,
                    "perMin": 120
                },
                {
                    "part": "Water",
                    "amount": 18,
                    "perMin": 180
                }
            ],
            "products": [
                {
                    "part": "AluminaSolution",
                    "amount": 12,
                    "perMin": 120,
                    "isByProduct": false
                },
                {
                    "part": "Silica",
                    "amount": 5,
                    "perMin": 50,
                    "isByProduct": true
                }
            ],
            "building": {
                "name": "oilrefinery",
                "power": "8.5"
            },
            "isAlternate": false,
            "isFicsmas": false
        },

[Maelstromeous]

Or not... apparently I can't read the fact that water is a byproduct and was used internally... that's a visualisation issue akin to #18

[Maelstromeous]

Wrote a test to confirm this, and can confirm they are heavily broken.

[samsmithnz]

I don't see where this is broken. The AL example above appears to be working - with the exception of the byproducts - which is well documented in other issues.

[Maelstromeous]

If you're happy with the recent parser fixes and the template tests and there's no "exotic" fluid stuff we need to handle then happy to close it off. I would like to see some resting around e.g. Excited matter.

Also gases?

[samsmithnz]

gases are simpler than they sound, they are liquids with no head-lift requirements.

[Maelstromeous]

Alright, I'll close this off for now then since our confidence has increased.