satisfactorymodding / SatisfactoryModManager

A mod manager for easy installation of mods and modloader for Satisfactory
GNU General Public License v3.0
360 stars 77 forks source link

Download rate shown is incorrect #121

Closed klAvAx closed 2 years ago

klAvAx commented 3 years ago

Description: I just noticed that SMM shows bogus download rate which is actually impossible to get with my internet connection, also shown download rate shown is almost always increasing and not fluctuating like it should.

Bug: Shown download rate shows incorrect download rate average

Shown download rate:

Untitled

Internet speed average tested with Speedtest after mod updates finished:

real speed
Borketh commented 2 years ago

Looks fine to me... You might be misreading the information given. The information is displayed as A files: B | C / D | E | F where A = number of files B = percent completion (calculated as C÷D) C = current amount of data downloaded (measured in megabytes) D = total amount of data required to be dowloaded (measured in megabytes) E = current download speed (measured in kbps - oof) F = predicted time to finish downloading (D-C) ÷ E

Your maximum speed according to speedtest.net is one megabits per second, or 1,000,000 bits/sec ~~SMM is downloading at 374.38 kilobits per second, or 374,380 bits/sec - well under your theoretical maximum speed. At this speed, that amount of data would take about 16.6 minutes to download. 46.63 Megabytes (373040000 bits) ÷ 374380 bits/sec ÷ 60 sec/min = 16.6070125 minutes~~

Borketh commented 2 years ago

Also, you may want to consider switching internet providers, since Megabit speeds are painfully slow.

klAvAx commented 2 years ago

Thanks for a reply, here where i live all ISP's have the same abysmal internet speed, ADSL on the end of the line, theoretical maximum of 6Mbps and real life maximum of 2Mbps from the monitoring i've done... From the stuff i heard about modernization i have only hope left to wait for better ahem times related to internet speed. Anyway from the acronyms i have met usually when someone writes KB (note the caps) they usually mean Kilobytes which is 8 times of kilobit, maybe my logic is flawed but i kind of believe the software should show Kb/s if its kilobits. Most of the other software does the same, even on linux i see KB/s which never exceeds 250KB/s

P.S. Currently my ISP connection maximum is ~2Mbit/s so that would be roughly 244.14KiB/s or 250KB/s so displayed speed such as 374.38KB/s is not possible more likely it is 45.7KiB/s or 46.8KB/s, Even with 1Mbit/s that would be correct because maximum for that is 122.07KiB/s or 125KB/s

Borketh commented 2 years ago

Ah I see, yeah that is somewhat confusing.

klAvAx commented 2 years ago

Yeah no worries, first time when i saw speed exceeding by connection limit i didn't believe it :D and second time i made sure to grab a screenshot :) It could be as simple as dividing by 8 or maybe changing some multiplication if there is any, it could be so that you are converting from KB/s back to Kb/s :)

You could do some tests locally with chrome dev tools and limiting speed, i believe this is an electron app + vue, you could even replicate my situation with chrome dev tools speed limiting :)

klAvAx commented 2 years ago

For example i am updating ETS2 via Steam now and stats look like this, Note the peak speed:

steam pvz
mircearoata commented 2 years ago

What AstroFloof said is incorrect, the rate SMM displays is in KB/s, not Kb/s, since the library it's using (which doesn't go through the chromium devtools network tab and limit) reports the progress in bytes.

However, it keeps the speed of the last chunk downloaded of every file and still adds it to the total download speed, even though that download has finished. I fixed that earlier today, along with showing the average download speed of the last couple of seconds rather than of the whole download. I will release the update soonTM after I get around to finishing the rest of the stuff I was working on.

klAvAx commented 2 years ago

Glad to hear, figures it has something to do with a library and averaging as i suspected :)

mircearoata commented 2 years ago

SMM v2.6.0 now properly removed finished downloads from the speed calculation.