Using the install button on the website doesn't work properly with SMM3

satisfactorymodding / SatisfactoryModManager

A mod manager for easy installation of mods and modloader for Satisfactory

GNU General Public License v3.0

356 stars 77 forks source link

Using the install button on the website doesn't work properly with SMM3 #188

Closed Th3Fanbus closed 7 months ago

Th3Fanbus commented 7 months ago

Haven't tried reproducing, but https://discord.com/channels/555424930502541343/555782140533407764/1205991804995113040

Pressing the Install button on the website seems to pass 9mwuEBapJ7orMt to SMM (error is intentional, to show the smmanager:// URL):

And SMM uses that as modref for some reason.

I believe the fix (get the modref from the mod files or similar) should be implemented in SMM.

mircearoata commented 7 months ago

SMM has always expected the mod reference in the URI, since it does not work in any way with mod IDs. It looks like all install buttons (the one on the mod card in the mods list and on the home page, and the ones in the mod version "tab"), except for the ones in the latest version section of the mod details, which specifically passes the modID, because it was previously a download button, and this was missed when turning it into an install button https://github.com/satisfactorymodding/smr-frontend/blob/staging/src/lib/components/mods/ModLatestVersions.svelte#L54