satisfactorymodding / smr-api

Satisfactory Mod Repository (SMR) API
https://ficsit.app
GNU General Public License v3.0
6 stars 8 forks source link

fix: correct SeparateMod filter for file extensions #19

Closed porisius closed 1 year ago

porisius commented 1 year ago

HasPrefix > HasSuffix

codecov-commenter commented 1 year ago

Codecov Report

Base: 17.17% // Head: 17.17% // No change to project coverage :thumbsup:

Coverage data is based on head (547cd22) compared to base (7b4f778). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## staging #19 +/- ## ======================================== Coverage 17.17% 17.17% ======================================== Files 104 104 Lines 5309 5309 ======================================== Hits 912 912 Misses 4296 4296 Partials 101 101 ``` | [Impacted Files](https://codecov.io/gh/satisfactorymodding/smr-api/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=satisfactorymodding) | Coverage Δ | | |---|---|---| | [storage/storage.go](https://codecov.io/gh/satisfactorymodding/smr-api/pull/19/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=satisfactorymodding#diff-c3RvcmFnZS9zdG9yYWdlLmdv) | `5.85% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=satisfactorymodding). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=satisfactorymodding)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

porisius commented 1 year ago

This fix doesn't fix everything that is needed, it does what is subscribed and works as intended, but there's more that needed changing. Closing PR until the validation stuff is ready.