search

satisfactorymodding / smr-api

Satisfactory Mod Repository (SMR) API
https://ficsit.app
GNU General Public License v3.0
6 stars 8 forks source link

fix: url encode filename for separated targets #44

Closed budak7273 closed 7 months ago

budak7273 commented 9 months ago

https://discord.com/channels/555424930502541343/830842478956642354/1198311921326243962

codecov-commenter commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (89860fa) 16.95% compared to head (c83420e) 16.95%.

Files Patch % Lines
storage/storage.go 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## staging #44 +/- ## =========================================== - Coverage 16.95% 16.95% -0.01% =========================================== Files 103 103 Lines 5437 5438 +1 =========================================== Hits 922 922 - Misses 4414 4415 +1 Partials 101 101 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mircearoata commented 9 months ago

I've also now noticed that RenameVersion is also not correctly escaping the filename, it's only escaping the mod's name, and not the version, which is what causes mods that use build metadata in the version (+build.1234) to fail, so that one should need a similar fix of encoding the filename.

We could also consider using the mod references in the file names (this system predates those), which would avoid special characters in the mod name part of the filename, though versions should still be encoded for the reason above, so all this encoding mess would still be the same

budak7273 commented 7 months ago

Superseded by #47