search

satisfactorymodding / smr-api

Satisfactory Mod Repository (SMR) API
https://ficsit.app
GNU General Public License v3.0
6 stars 8 forks source link

fix: do not add zero-length filenames in per-target zips #45

Closed Th3Fanbus closed 8 months ago

Th3Fanbus commented 8 months ago

Rewrite the compound conditional to avoid future confusions. This bug has gone unnoticed for so long because Alpakit-generated zip files do not contain folder entries when iterating with a zipReader. However, manually generated zip files, e.g. ContentLib mods, could contain folder entries depending on the zipping program used. The resulting zero-length folder in the per-target zips breaks SMM2 on Windows, but not SMM3.

Th3Fanbus commented 8 months ago

It's complaining about https://academy.unrealengine.com/ being unreachable (HTTP 504)

codecov-commenter commented 8 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ab5d04f) 16.95% compared to head (9620640) 16.94%.

Files Patch % Lines
storage/storage.go 0.00% 5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #45 +/- ## ========================================== - Coverage 16.95% 16.94% -0.01% ========================================== Files 103 103 Lines 5437 5440 +3 ========================================== Hits 922 922 - Misses 4414 4417 +3 Partials 101 101 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.