satisfactorymodding / smr-frontend

Next generation Satisfactory Modding Repository (SMR) frontend
https://satisfactorymodding.github.io/smr-frontend/main/
GNU General Public License v3.0
6 stars 24 forks source link

Page head element does not change when navigating between pages #90

Open budak7273 opened 1 year ago

budak7273 commented 1 year ago

Example:

  1. Navigate directly to this link: https://ficsit.app/mod/FicsitRemoteMonitoring
  2. Notice the page title is FicsitRemoteMonitoring - SMR
  3. Click the "home" link on the page
  4. Notice the page title is still FicsitRemoteMonitoring - SMR
  5. Navigate directly to this link in a new tab: https://ficsit.app/
  6. Notice the page title is Home - SMR
budak7273 commented 1 year ago

Might be resolved by the framework update, see https://discord.com/channels/555424930502541343/830842478956642354/1123695901039415307

budak7273 commented 1 year ago

elements in head are being duplicated. should:tm: be resolved by svelte 4 https://discord.com/channels/555424930502541343/830842478956642354/1126043859542081606

budak7273 commented 1 year ago

https://github.com/sveltejs/kit/issues/10089

QuantumPickleJar commented 2 months ago

With a simplified load function in +page.ts, the tags don't seem to be getting duplicated anymore, though I'm having some difficulty verifiying this as I get a ton of networking errors trying to check FicsitRemoteMonitoring (for example).

Reduced Load Function: // src/routes/+page.ts

export const load = async () => ({
  meta: {
    title: 'Mods',
    description: 'Mods available from the Satisfactory Mod Repository',
    image: '/assets/favicon.ico',
  },
});