feat: syntax-highlighting dark/light themed

satnaing / astro-paper

A minimal, accessible and SEO-friendly Astro blog theme

https://astro-paper.pages.dev/

MIT License

2.13k stars 440 forks source link

feat: syntax-highlighting dark/light themed #242

Closed FjellOverflow closed 5 months ago

FjellOverflow commented 5 months ago

When site theme is toggled, the syntax-highlighted code blocks stay dark themed. For a more consistent look and feel, I feel those code-blocks should switch theme as well. This PR

configures dark and light syntax-highlight theme in astro.config.ts
adds css to set respective theme in dark mode, according to docs

Solarized light was arbitrarily chosen as light theme as its background-color is different from the site background.

satnaing commented 5 months ago

While this is a good change, I think this is a little bit subjective. For me, I'd like to have dark theme for code blocks even in the site light theme.

So, would you like to answer this in the discussion (FAQ) section? If so, I can create a new discussion and then mark yours as answer.

FjellOverflow commented 5 months ago

Sure!

satnaing commented 5 months ago

I've opened a new FAQ just now. You can drop your answer there. Thanks

benjaminrae commented 5 months ago

While this is a good change, I think this is a little bit subjective. For me, I'd like to have dark theme for code blocks even in the site light theme.

So, would you like to answer this in the discussion (FAQ) section? If so, I can create a new discussion and then mark yours as answer.

While I completely agree with you, having different themes could definitely be useful. In my case, it's probably something I'll implement because the syntax-highlight theme I like blends in way too much with the background color for my dark theme. So keeping this possibility documented somewhere is probably pretty useful.