fix: tweaking theme provider

satnaing / shadcn-admin

Admin Dashboard UI built with Shadcn and Vite.

https://shadcn-admin.netlify.app/

MIT License

902 stars 185 forks source link

fix: tweaking theme provider #49

Closed kohinoor98 closed 2 days ago

kohinoor98 commented 3 weeks ago

solves #48

satnaing commented 2 days ago

Thanks for pointing out this issue and PR.

I also made a couple of changes

disable eslint warning
update setThemeState to _setTheme

kohinoor98 commented 2 days ago

Thanks for such a beautiful template! If there are any additional issues I could work on, plz let me know, would love to contribute

satnaing commented 2 days ago

Thanks @kohinoor98 You can try the ESLint upgrading issue #24 However, when I opened that issue, there was no stable React19-compatible ESLint version. I'm not sure if it's out now or not tho. You can try that if you want (or if you're interested in doing that)

kohinoor98 commented 2 days ago

For sure, let me check it over the weekend!