search

sato9hara / defragTrees

Python code for tree ensemble interpretation
MIT License
83 stars 22 forks source link

Possible printout inequality error #4

Closed stewu5 closed 3 years ago

stewu5 commented 3 years ago

Based on the codes in the "check" function, l[1] == 0 represents "value <= x" and l[1] == 1 represents "x < value". However, in the print implementation, it seems like l[1] == 0 represents "value < x" and l[1] == 1 represents "x <= value". Am I misunderstanding the implementation, or there is actually an error?

sato9hara commented 3 years ago

Thank you for pointing out the inconsistency between check and __str__. I have updated __str__, and it would be now consistent with check.