Support segments in recorder

satori-com / satori-video-sdk-cpp

Satori Video C++ SDK

Other

5 stars 7 forks source link

Support segments in recorder #259

Closed khabinov closed 6 years ago

khabinov commented 6 years ago

Split mkv_sink_impl into 2 pieces:

first piece is only responsible for writing frames into files,
second piece is subscribed to video stream and uses first piece to manage files.

Resolves https://github.com/satori-com/satori-video-sdk-cpp/issues/191.

Not final yet, have a few TODOs that I want to address in this PR.

khabinov commented 6 years ago

I'm ok with changes, the only question I have: could we use --time-limit option for this feature? In this case we could also implement --frame-limit as well in future

To avoid confusion now I'm using --segment-duration parameter. It definitely makes sense to add another parameter like --segment-frames or --segment-frames-count. Probably, I can make it in a separate PR, added a TODO comment.