search

satoshilabs / slips

SatoshiLabs Improvement Proposals
Creative Commons Attribution Share Alike 4.0 International
1.51k stars 1.72k forks source link

Slip132: doesn't specify what scripts the script-hash types are for #315

Closed afk11 closed 6 years ago

afk11 commented 6 years ago

https://github.com/satoshilabs/slips/blob/master/slip-0132.md

I noticed in a discussion recently that this is meant to follow electrum in the prefixes used. I had made the mistake of assuming the P2SH, P2WSH, P2SH|P2WSH types referred to P2PKH inside the respective script type, but no, that it was for multisig.

Could the document be updated to reflect that they refer to multisig? The term isn't mentioned anywhere. I started implementing P2PKH inside these types as 'slip132' assuming they all referred to key hash types.

prusnak commented 6 years ago

These script do not refer to multisig, explanation is below.

P2PKH is Pay to Public Key Hash P2SH is Pay to Script Hash P2WPKH is Pay to Witness Public Key Hash P2WSH is Pay to Witness Script Hash P2WSH in P2SH is Pay to Witness Script Hash wrapped in Pay to Script Hash P2WPKH in P2SH is Pay to Witness Public Key Hash wrapped in Pay to Script Hash

afk11 commented 6 years ago

P2SH, P2WSH and P2WSH in P2SH aren't definite script types, they just say that some script type is wrapped in some form.

It not specifying the type of the redeem/witness script was the confusion here, hence the suggestion!

Thanks anyway.

prusnak commented 6 years ago

I get your point now. If you have a particular idea how to improve the document, please, send the pull request.

afk11 commented 5 years ago

@prusnak I submitted a pull request regarding this issue. It only modifies the Zp & Yp prefixed keys, as I have yet to encounter xpub/xprv prefixes used in a P2SH context. Is there anywhere that actually makes use of that, and what script type have they nested inside P2SH?