satoshinm / NetCraft

Web-based fork of fogleman/Craft ⛺
https://satoshinm.github.io/NetCraft/
MIT License
57 stars 13 forks source link

Update to emscripten sdk v1.37.12 #122

Closed satoshinm closed 7 years ago

satoshinm commented 7 years ago

emsdk v1.37.12 was just released: https://github.com/urho3d/emscripten-sdk/releases/tag/v1.37.12

Should update it for building on CI, will allow reducing the amount of code I need to patch into emscripten v1.37.9 (https://github.com/satoshinm/NetCraft/blob/de4fc6f9f1ca225707b9a8169909c83ef741b4c4/src/emscripten-1.37.9%2Bnetcraftfixes.patch)

satoshinm commented 7 years ago

I ran emsdk update, it finds 1.37.12:

src $ emsdk update-tags
Fetching all tags from Emscripten Github repository...
Done. 99 tagged releases available, latest is 1.37.12.
Fetching all tags from Binaryen Github repository...
Done. 26 tagged Binaryen releases available, latest is 1.37.12.
Fetching all precompiled Nightly versions..
Downloading: /Users/admin/games/wasm/emsdk-portable/llvm-nightlies-32bit.txt from https://s3.amazonaws.com/mozilla-games/emscripten/packages/llvm/nightly/osx_32bit/index.txt
Downloading: /Users/admin/games/wasm/emsdk-portable/llvm-nightlies-64bit.txt from https://s3.amazonaws.com/mozilla-games/emscripten/packages/llvm/nightly/osx_64bit/index.txt
Downloading: /Users/admin/games/wasm/emsdk-portable/emscripten-nightlies.txt from https://s3.amazonaws.com/mozilla-games/emscripten/packages/emscripten/nightly/linux/index.txt
Fetching all precompiled tagged releases..
Downloading: /Users/admin/games/wasm/emsdk-portable/llvm-tags-32bit.txt from https://s3.amazonaws.com/mozilla-games/emscripten/packages/llvm/tag/osx_32bit/index.txt
Downloading: /Users/admin/games/wasm/emsdk-portable/llvm-tags-64bit.txt from https://s3.amazonaws.com/mozilla-games/emscripten/packages/llvm/tag/osx_64bit/index.txt

but then emsdk list doesn't show it - what am I missing?

The following precompiled SDKs are available for download: (Run "./emsdk update" to pull in the latest list)
         sdk-nightly-1.37.9-2017_03_29_18_44-64bit
         sdk-nightly-1.37.9-2017_03_29_20_27-64bit
         sdk-1.30.0-64bit         
         sdk-1.34.1-64bit         
         sdk-1.35.0-64bit         
         sdk-1.37.8-64bit         
    *    sdk-1.37.9-64bit           INSTALLED

is emsdk v1.37.12 not actually released yet, is 1.37.9 the newest? But https://github.com/urho3d/emscripten-sdk/tags shows 1.37.9 and then 1.37.12...

satoshinm commented 7 years ago

Aha, there is an SDK update but it is not precompiled, only from source:

The following SDKs can be compiled from source:
         sdk-incoming-64bit       
         sdk-master-64bit         
         sdk-tag-1.37.11-64bit    
         sdk-tag-1.37.12-64bit    

when would it be expected to be available precompiled?

satoshinm commented 7 years ago
emsdk install sdk-1.37.12-64bit
emsdk activate sdk-1.37.12-64bit

works to download precompiled 1.37.12