satoshinm / NetCraft

Web-based fork of fogleman/Craft ⛺
https://satoshinm.github.io/NetCraft/
MIT License
56 stars 13 forks source link

Liquids should target block underneath when mining #179

Open satoshinm opened 7 years ago

satoshinm commented 7 years ago

Since they cannot be mined, when targeting a liquid block (lava/water), it should be ignored for block targeting and instead target the block behind it, not the infinitely hard liquid block itself:

screenshot-netcraft-2017-06-04t07_08_38 339z

https://github.com/satoshinm/NetCraft/issues/72 Liquids

satoshinm commented 7 years ago

Put another way, liquid block should be considered "transparent" for the purpose of block targeting.

Similar to https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/entity/LivingEntity.html#getTargetBlock-java.util.Set-int-:

Block getTargetBlock(Set<Material> transparent,
                     int maxDistance)
Gets the block that the living entity has targeted.
Parameters:
transparent - HashSet containing all transparent block Materials (set to null for only air)
satoshinm commented 7 years ago

Also clouds