satoshinm / NetCraft

Web-based fork of fogleman/Craft ⛺
https://satoshinm.github.io/NetCraft/
MIT License
57 stars 13 forks source link

Update glfw to fix build and runtime warnings #190

Closed satoshinm closed 7 years ago

satoshinm commented 7 years ago

When I run within Xcode (but not from Terminal), this warning is logged:

2017-06-11 13:28:21.272422-0700 craft[16167:359971] [General] ERROR: Setting <GLFWContentView: 0x60f0000401e0> as the first responder for window <GLFWWindow: 0x611000053100>, but it is in a different window ((null))! This would eventually crash when the view is freed. The first responder will be set to nil.
(
    0   AppKit                              0x00007fff95bc157e -[NSWindow _validateFirstResponder:] + 578
    1   AppKit                              0x00007fff9531a140 -[NSWindow _setFirstResponder:] + 31
    2   AppKit                              0x00007fff953b8001 -[NSWindow _realMakeFirstResponder:] + 448
    3   craft                               0x000000010053da46 _glfwPlatformCreateWindow + 2534
    4   craft                               0x0000000100564e69 glfwCreateWindow + 2089
    5   craft                               0x0000000100512361 main + 97
    6   libdyld.dylib                       0x00007fffbec7a515 start + 1
    7   ???                                 0x0000000000000001 0x0 + 1
)
Program ended with exit code: 0
satoshinm commented 7 years ago

Found same error but no solution: https://stackoverflow.com/questions/40405438/xcode-8-1-glfwwindow-first-responder-issue

Time to update glfw? Last updated to 3.2.1 but these are fixed: https://github.com/glfw/glfw/issues/908 https://github.com/glfw/glfw/issues/909