New chunks sometimes don't generate/load on web client (world gaps) - remove browser threading?

[satoshinm]

They do in the native client, but not web, sometimes. Maybe a symptom of sqlite? https://github.com/satoshinm/NetCraft/issues/2

View from orthographic mode ("f" key):

This does not matter much for my first use case (https://github.com/satoshinm/WebSandboxMC, since it only shows a small section of the world, all sent by the server using "B," commands, not generated on the client), but it is important for playing the game locally, or potentially also using remote Python servers.

[satoshinm]

Curiously, new chunks generate sometime, but not always (web only - still thinking this is related to some port. Maybe tinycthread?):

[satoshinm]

There seems to be fewer holes when changing #define WORKERS 4 to 1 in src/main.c, but have not confirmed

[satoshinm]

Maybe remove tinycthread and generate (client) chunks synchronously for now (shouldn't affect online mode, when the server generates the chunks). Wouldn't mind having one fewer dependency.

[satoshinm]

Trying with -s USE_PTHREADS=1 to emcc, rebuilding:

Scanning dependencies of target craft
[  4%] Building C object CMakeFiles/craft.dir/src/item.c.o
[  9%] Linking C executable craft.html
INFO:root:generating system library: libc-mt.bc... (this will be cached in "/Users/admin/.emscripten_cache/asmjs/libc-mt.bc" for subsequent builds)
INFO:root: - ok
INFO:root:generating system library: pthreads.bc... (this will be cached in "/Users/admin/.emscripten_cache/asmjs/pthreads.bc" for subsequent builds)
INFO:root: - ok
INFO:root:generating system library: dlmalloc_threadsafe.bc... (this will be cached in "/Users/admin/.emscripten_cache/asmjs/dlmalloc_threadsafe.bc" for subsequent builds)
INFO:root: - ok
[100%] Built target craft

the client immediately fails with:

no such block found: Cobble (oops, separate issue: https://github.com/satoshinm/NetCraft/issues/162)

exception thrown: TypeError: Argument 9 ('pixels') to WebGLRenderingContextBase.texImage2D must be an instance of ArrayBufferView,texImage2D@[native code]
_glTexImage2D@file:///Users/admin/games/wasm/NetCraft/build/craft.js:9357:23
_load_png_texture@file:///Users/admin/games/wasm/NetCraft/build/craft.js:30928:15
_load_main_texture@file:///Users/admin/games/wasm/NetCraft/build/craft.js:30945:19
_main@file:///Users/admin/games/wasm/NetCraft/build/craft.js:27093:20
file:///Users/admin/games/wasm/NetCraft/build/craft.js:65743:24
callMain@file:///Users/admin/games/wasm/NetCraft/build/craft.js:66127:30
doRun@file:///Users/admin/games/wasm/NetCraft/build/craft.js:66191:60
file:///Users/admin/games/wasm/NetCraft/build/craft.js:66202:12
TypeError: Argument 9 ('pixels') to WebGLRenderingContextBase.texImage2D must be an instance of ArrayBufferView

Threads are not even strictly needed on the web client because receiving network data occurs asynchronously anyway, and terrain generation occurs remotely.

[satoshinm]

This may be obviated at least when online with https://github.com/satoshinm/NetCraft/issues/188, but for completeness ought to still fix offline local mode world holes, probably by removing tinycthread in emscripten

[satoshinm]

With https://github.com/satoshinm/NetCraft/issues/172 the world holes now have a visible lower layer, due to the bedrock: