satoshinm
commented
7 years ago Making progress but running into problems porting the sign. First of all note there is org.bukkit.material.Sign a MaterialData for setFacingDirection()/getFacing() BlockState, and org.bukkit.block.Sign a BlockState for getLines()/setLines(), the sign text. This is how signs were created using the deprecated methods (simplified slightly):
public void clientNewSign(ChannelHandlerContext ctx, int x, int y, int z, int face, String text) {
byte data = 0;
switch (face) {
case 0: // west
data = 4; // west
x -= 1;
break;
case 1: // east
data = 5; // east
x += 1;
break;
case 2: // north
data = 2; // north
z -= 1;
break;
case 3: // south
data = 3; // south
z += 1;
break;
}
Location location = toBukkitLocation(x, y, z);
Block block = location.getWorld().getBlockAt(location);
block.setType(Material.WALL_SIGN);
block.setData(data); // deprecated!
webSocketServerThread.log(Level.FINEST, "setting sign at "+location+" data="+data);
BlockState blockState = block.getState();
if (!(blockState instanceof Sign)) {
webSocketServerThread.log(Level.WARNING, "failed to place sign at "+location);
return;
}
Sign sign = (Sign) blockState;
sign.setLine(0, text);
sign.update();
}To remove block.setData(data), the plan is to use BlockState to set the direction with org.bukkit.material.Sign, trying something like this:
BlockFace blockFace;
switch (face) {
case 0: // west
blockFace = BlockFace.WEST;
x -= 1;
break;
case 1: // east
blockFace = BlockFace.EAST;
x += 1;
break;
default:
case 2: // north
blockFace = BlockFace.NORTH;
z -= 1;
break;
case 3: // south
blockFace = BlockFace.SOUTH;
z += 1;
break;
}
org.bukkit.material.Sign signDirection = new org.bukkit.material.Sign();
signDirection.setFacingDirection(blockFace);North and West are correct but East and South are off by a block. And Glowstone chokes in notifySignChange:
public void notifySignChange(Location location, Material material, BlockState blockState, String[] lines) {
int x = toWebLocationBlockX(location);
int y = toWebLocationBlockY(location);
int z = toWebLocationBlockZ(location);
BlockFace blockFace = BlockFace.NORTH;
if (blockState.getData() instanceof org.bukkit.material.Sign) {
org.bukkit.material.Sign sign = (org.bukkit.material.Sign) blockState.getData();
if (sign != null) {
blockFace = sign.getFacing(); // HERE
}
}sign is non-null, but it crashes in Sign.java:
21:03:28 [SEVERE] [WebSandboxMC] Error while executing GlowTask{id=49, plugin=WebSandboxMC v1.8.0, sync=true: io.github.satoshinm.WebSandboxMC.ws.WebSocketFrameHandler$1@266f960e}
java.lang.NullPointerException
at org.bukkit.material.Sign.getFacing(Sign.java:147)
at io.github.satoshinm.WebSandboxMC.bridge.BlockBridge.notifySignChange(BlockBridge.java:596)
at io.github.satoshinm.WebSandboxMC.bridge.BlockBridge.setBlockUpdate(BlockBridge.java:299)
at io.github.satoshinm.WebSandboxMC.bridge.BlockBridge.sendWorld(BlockBridge.java:128)
at io.github.satoshinm.WebSandboxMC.ws.WebSocketServerThread.handleNewClient(WebSocketServerThread.java:175)
at io.github.satoshinm.WebSandboxMC.ws.WebSocketFrameHandler$1.run(WebSocketFrameHandler.java:47)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at net.glowstone.scheduler.GlowTask.run(GlowTask.java:167)
at net.glowstone.scheduler.GlowScheduler.pulse(GlowScheduler.java:152)
at net.glowstone.scheduler.GlowScheduler.lambda$start$0(GlowScheduler.java:83)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)in Sign.java in Bukkit:
public BlockFace getFacing() {
} else {
return getAttachedFace().getOppositeFace();
}so getAttachedFace() is returning null, wrong data?
if (isWallSign()) {
byte data = getData();
switch (data) {
case 0x2:
return BlockFace.SOUTH;
case 0x3:
return BlockFace.NORTH;
case 0x4:
return BlockFace.EAST;
case 0x5:
return BlockFace.WEST;
}
return null;
} else {
return BlockFace.DOWN;
}wall signs should only be 2, 3, 4, or 5.
https://github.com/satoshinm/WebSandboxMC/issues/66