search

satoshinm / modpack

0 stars 0 forks source link

GT++: You're not using the latest recommended version of GT++, consider updating (1.4.9.86 is recommended, but using the latest, 1.5.0.1) #21

Open satoshinm opened 7 years ago

satoshinm commented 7 years ago

A few seconds after the player logins in, GT++ says it is not the latest:

GT++: You're not using the latest recommended version of GT++, consider updating

2017-06-21_20 55 48

Check if updating would fix https://github.com/satoshinm/modpack/issues/13

satoshinm commented 7 years ago

modlist.md is wrong it said GT++ 1.4.9.86-Beta, but the filename is GT-PlusPlus-1.5.0.1-Beta.jar. https://github.com/draknyte1/GTplusplus/wiki links to recommended version https://mods.curse.com/mc-mods/minecraft/252448-gregtech-gt-gtplusplus but this is older, GT-PlusPlus-1.4.9.86-Beta.jar. Other downloads https://mods.curse.com/mc-mods/minecraft/252448-gregtech-gt-gtplusplus#t1:other-downloads only has these same two versions:

GT++ v1.5.0.1-Beta Beta 1.7.10 790 Apr 29, 2017 GT++ v1.4.9.86-Release Release 1.7.10 1,893 Mar 4, 2017

Therefore, I believe the warning is wrong - or technically correct because 1.5.0.1-beta is not the latest "recommended" version, even though it is the latest version. Can GT++ update checking be disabled?

Message is logged in https://github.com/draknyte1/GTplusplus/blob/7ec08239a8853c0c38c7e6add5a90629219ce48f/src/Java/gtPlusPlus/core/handler/events/LoginEventHandler.java#L43, it gets the latest version https://github.com/draknyte1/GTplusplus/blob/84f44b23393ee7f565de4eac5ffeaa235c356882/src/Java/gtPlusPlus/core/lib/CORE.java#L33 with:

    public static final String MASTER_VERSION = NetworkUtils.getContentFromURL("https://raw.githubusercontent.com/draknyte1/GTplusplus/master/Recommended.txt").toLowerCase();

https://raw.githubusercontent.com/draknyte1/GTplusplus/master/Recommended.txt returns 1.4.9.86-Beta. Should be easy enough to compile out this check.