satoshipay / solar

🌞 Stellar wallet. Secure and user-friendly.
https://solarwallet.io
MIT License
192 stars 57 forks source link

App crashes when localStorage quota is exceeded #1278

Closed ebma closed 3 years ago

ebma commented 3 years ago

When searching for assets in Solar many entries for the home_domain of asset issuers are added to the cache in localStorage. Apparently sometimes these take up so much space that the quota of the localStorage is exceeded. This error should be caught to prevent the application from crashing.

I tried reproducing this issue on desktop (macOS) but apparently it is pretty hard to fill the localStorage quota so much as to encounter this error. I tried searching for assets starting with an "s" and scrolling through the assets list filled the localStorage with plenty of entries but I still did not encounter this error once.

Screenshot_20211005-052626