Correct install.php - Githubissues

satrun77 / tinyissue

Simple Issue Tracking for Teams

MIT License

48 stars 6 forks source link

Closed oliverpool closed 8 years ago

oliverpool commented 8 years ago

Hi,

thank you for this project, that I'm trying to install (on PHP5.6).

I think that there are some issues with the dbDriver selection during the installation:

the Illuminate\Console\Command already manages the default argument, so the askQuestion can be simplified.
the choices should not be prefixed with pdo_
I have an empty db password: it should be the default

satrun77 commented 8 years ago

Thanks for the pull request.

satrun77 commented 8 years ago

Unfortunately, the patch failed. The password still required and the database driver failing with the following error "Unsupported driver [l]" :(

You can choose between: 1) You fix the patch, and I will test it again. 2) I can modify your patch and merge it.

Thanks for your work

oliverpool commented 8 years ago

I'll let you modify it (I now use another fork of tinyissue: https://github.com/pixeline/bugs because it support tags update)