search

satrun77 / tinyissue

Simple Issue Tracking for Teams
MIT License
48 stars 6 forks source link

Kanban updates, german translation, Menu updates #45

Closed nickbe closed 8 years ago

nickbe commented 8 years ago

Menu responsiveness is enhanced, german language files, visual updates of kanban board.

nickbe commented 8 years ago

GitHub - I think I'm getting the hang of it now. I wish you a happy easter weekend ^^

nickbe commented 8 years ago

Shall I remove the logo then and make a new pull request? Anything else you want to have changed?

satrun77 commented 8 years ago

How about using gravatar (https://en.gravatar.com/) instead of the image in the pull request?

satrun77 commented 8 years ago

I looked into all of the code in your pull request. Most things are good. I have some questions about the changes to .gitignore that are related to window.

Sometime soon, I will make minor code changes & clean-up and then merge to develop branch.

Thanks for your work.

satrun77 commented 8 years ago

The latest commit includes the new font but you have not used it. I will not merge this commit here. You can include the font and the changes to the LESS files in another pull request.

nickbe commented 8 years ago

I wanted to include the font in the less files, but (shame on me) I didn't know how actually. Until recently I was basically a windows programmer. Then I had to work with PHP and other stuff like CSS, JS and so on. Frameworks like bootstrap are still very new to me. I learn on the fly here. Same goes for LESS. Maybe you can point me in the right direction for including the fonts (not referencing google, but as static local font files)?

nickbe commented 8 years ago

You mentioned Gravatar.... I think it's basically a good thing. I'm using it myself. But I also like having as few external dependencies as possible.

So as an optional feature: great. But I also would wish to let the users upload their own image (which is even more simple on mobiles).

satrun77 commented 8 years ago

LESS files are just CSS with extra features.

Include font file in css: https://css-tricks.com/snippets/css/using-font-face/

nickbe commented 8 years ago

Thanks. I didn't think it was that easy.

Is it ok for you if you take to current pull request as it is? I'll try to make better pull requests for all future changes.

satrun77 commented 8 years ago

Is it ok for you if you take to current pull request as it is? I'll try to make better pull requests for all future changes.

Yes that is ok

satrun77 commented 8 years ago

I have reviewed and manually merged each change. Some changes were not merged such as the fonts and the hardcoded image.

New fonts: can be moved to a separate PR with LESS changes. Image: used Gravatar. There is possibility to have an option to upload an image. This can be another PR.