search

sattvik / leinjacker

A library for Leiningen plug-in authors.
42 stars 11 forks source link

No release for 0.4.3 to support :managed-dependencies #14

Closed MatthewDarling closed 5 years ago

MatthewDarling commented 6 years ago

I'd like to take the results of my previous PR and get them integrated into the plugins that use leinjacker. In order to do that, there needs to be a Clojars release of 0.4.3.

If there's anything I can do to help make that happen, I'm happy to do so!

0xbase12 commented 6 years ago

Could you release 0.4.3 to fix issue with managed-dependencies

MatthewDarling commented 6 years ago

If you're in a rush, we set up a fork so we could start using :managed-dependencies in our projects. Just use [kirasystems/leinjacker "0.4.3"].

The trouble with plugins is I don't know of a way to control their dependencies from the outside. So we also forked codox to use that version of leinjacker, available as: [kirasystems/lein-codox "0.10.4"].

0xbase12 commented 6 years ago

Hi thanks for the workaround. Will use your fork. Thanks Matthew

tobias commented 6 years ago

I'll take a look at releasing 0.4.3 now. The build is broken with lein 2.8.1, so I'll see about fixing that first.

jameslintaylor commented 5 years ago

@tobias Any updates on a release cut?

MatthewDarling commented 5 years ago

Ah, looks like #15 has a relevant comment:

I tried to release 0.4.3 for #14, but lein release fails under lein 2.8.1 without this change to the midje versions.

So at a minimum that PR needs to go in before the release. May as well bring in #17 as well, for Clojure 1.10 support.

tobias commented 5 years ago

I finally got 0.4.3 out - sorry for the excessive delay: https://clojars.org/leinjacker/versions/0.4.3