search

saturday06 / VRM-Addon-for-Blender

VRM Importer, Exporter and Utilities for Blender 2.93 to 4.1
https://vrm-addon-for-blender.info
MIT License
1.25k stars 141 forks source link

Bug report: Rim Light Mix Incorrect #512

Open tdw46 opened 1 week ago

tdw46 commented 1 week ago

The below two nodes in your rimlight calc produce incorrect results:

image

Muting the resolves the problem.

To Reproduce

  1. Add a rim value to any MToon material.
  2. Export.
  3. Compare result in VRM app to Blender

Expected behavior

I expect a result that matches between blender and VRM app.

Screenshots

image image

Desktop:

Additional context

This problem is made worse when you consider that the addon re-appends the latest material nodes any time it is installed or updated. So if I make a tweak to fix this in the material of the file locally, it will get overridden by the append operation on next launch. Not everyone will know how to go into the source folders and adjust the material there.

saturday06 commented 6 days ago

The light information is required for the correct mtoon rimlight, but it is currently unavailable.

I would implement the implementation to obtain light information. https://github.com/saturday06/VRM-Addon-for-Blender/pull/515 However, it takes time.

tdw46 commented 5 days ago

This makes sense. Thanks for the link to #515. In the meantime, will you mute or remove those two nodes because they give worse results for lookdev than if they are muted?

tdw46 commented 5 days ago

Forward render emulation in a deferred rendering pipeline ~~ wow, that will be impressive if you can do it! I did this with only direct lights in Unreal, which was already difficult. All those other light types will be a lot of work. 頑張って💪🏻

saturday06 commented 3 days ago

Thank you for your help. Those two nodes will be muted in the next version.

I won't mute all the inaccurate nodes, because most of them are currently inaccurate.