satvik-dixit / CPP

Python implementation of Cepstral Peak Prominence (CPP)
3 stars 1 forks source link

Reviewing first pass at CPP in python #1

Closed danielmlow closed 2 years ago

danielmlow commented 2 years ago

@satra , @satvik-dixit started from the implementation of the cepstrum I had for the UVP paper and computed the CPP from there. He also ran it in Praat to compare and he's getting slightly different results. Perhaps you can give the code a quick look to see if we're missing something. He thinks maybe smoothing.

Here are some resources in case they're useful:

About CPP:

Code:

satra commented 2 years ago

i can take a look tomorrow. but on a quick look, i would start with the functions already in librosa. there is no need to implement another cepstral extraction (learning is ok, but should switch to a library).

danielmlow commented 2 years ago

@satra so Librosa has only a clean implementation of the MFCCs, so perhaps @satvik-dixit uses these Python implementations of the cepstrum (without mel filters and DCT): https://github.com/python-acoustics/python-acoustics/blob/master/acoustics/cepstrum.py

Sees how results change with the different implementations.

And looks through the matlab implementation a bit more (perhaps gets it to run) and compare to Praat and try to copy the smoothing details into Python if needed.

danielmlow commented 2 years ago

Satvik used those implementations from the python-acoustics package and has also matched the outputs from the matlab implementation.