satya164 / PocketGear

A clean and simple Pokédex app for Pokémon GO
199 stars 54 forks source link

Bunch of fixes to make it runs on random machine #1

Closed Kureev closed 8 years ago

Kureev commented 8 years ago
satya164 commented 8 years ago

Removed Lato font as it's not bundled. If you provide me a font, I can add it back

You can find the Lato fonts here - https://github.com/satya164/pokematch/tree/master/android/app/src/main/assets/fonts

Fixed "Crypto not found" error. Package node-uuid doesn't work well on my machine (and seems on some others). So some guys forked it to react-native-uuid

Oh weird. It works fine on Android at least.

Linked react-native-vector-icons fonts to the project

The problem with linking react-native-vector-icons is, it adds unused native modules to our project as well as a bunch of icon fonts we don't use, which will increase the APK size (it's already big).

This tells gradle to just copy the MaterialIcons font at build time - https://github.com/satya164/pokematch/blob/master/android/app/build.gradle#L69

I guess the same applies for iOS (though since it uses system's JSC, file size should be much smaller). Is it possible to tell rnpm to just copy the fonts we need and do nothing else?