search

satya164 / react-native-tab-view

A cross-platform Tab View component for React Native
MIT License
5.13k stars 1.07k forks source link

Upgrade to last react-native-pager-view version #1343

Closed anthlasserre closed 2 years ago

anthlasserre commented 2 years ago

…Exception

Just to be up-to-date with the last react-native-pager-view version.

Motivation

Related to this issue this last react-native-pager-view version embed a bunch of critical fixs. I met randomly some of them on the app load when TabView is rendering for the first time.

Test plan

Nothing changes from the UI. Only one import from react-native-pager-view is different inside PagerViewAdapter.tsx.

Code formatting

Look around. Match the style of the rest of the codebase. Run yarn lint --fix before committing.

github-actions[bot] commented 2 years ago

Hey anthlasserre! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

mak12 commented 2 years ago

Hi @anthlasserre this PR wont work, because the implementation is changed for new PagerView, it no longer accepts children, instead it takes views from renderItem function. But still this change is important to be able to work with new Pager component.

mak12 commented 2 years ago

@satya164 any plans for this fix? its breaking code.

okwasniewski commented 2 years ago

Closing this, since it doesn't work. I will address upgrading react-native-pager-view in a separate PR