search

satya164 / react-native-tab-view

A cross-platform Tab View component for React Native
MIT License
5.14k stars 1.07k forks source link

[@react-navigation/material-top-tabs] gestureResponseDistance does not work when top tabs nested within a stack navigator #1372

Open krtejeda opened 2 years ago

krtejeda commented 2 years ago

Current behavior

Using the backwards swipe gesture to navigate backwards in the stack doesn't work if the swipe starts from inside the tab view content. The only time this gesture works is if the swipe starts on the tab bar itself or if swiping is disabled, likely because the gesture is not consumed in those instances.

https://user-images.githubusercontent.com/32690426/182309267-b5d0fd17-4248-407d-96bc-42ed49cbed5a.mov

Expected behavior

I expect that if I swipe backwards on the content, especially if there is no other content the tab bar can swipe to, the stack should navigate backwards.

Reproduction

https://snack.expo.dev/Yq_J20P3b

Platform

Environment

package version
react-native-tab-view 3.1.1
react-native-pager-view 5.4.25
react-native 0.68.1
expo 44.0.0
node 16.13.0
npm or yarn 8.5.0
github-actions[bot] commented 2 years ago

Couldn't find version numbers for the following packages in the issue:

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

The versions mentioned in the issue for the following packages differ from the latest versions on npm:

Can you verify that the issue still exists after upgrading to the latest versions of these packages?

github-actions[bot] commented 2 years ago

The versions mentioned in the issue for the following packages differ from the latest versions on npm:

Can you verify that the issue still exists after upgrading to the latest versions of these packages?

krtejeda commented 2 years ago

Yes the issue still persists on those versions

mikefogg commented 1 year ago

Any update on this @krtejeda ? Wondering if you got it to work... stuck in the same spot currently and can't find a way to let swiping back with react-navigation have any effect.