Please upgrade flow version. There are errors in flow 0.98.o

satya164 / react-native-tab-view

A cross-platform Tab View component for React Native

MIT License

5.14k stars 1.07k forks source link

Please upgrade flow version. There are errors in flow 0.98.o #759

Closed vasilich6107 closed 5 years ago

vasilich6107 commented 5 years ago

Current behaviour

Error ┈┈┈┈┈┈┈┈┈┈┈┈ node_modules/react-native-tab-view/src/TabBarItem.js:134:18

Cannot assign renderLabel !== undefined ? renderLabel : (...) => { ... } to renderLabel because in the return value:
 • Either null or undefined [1] is incompatible with null [2].
 • Or property @@iterator is missing in null or undefined [1] but exists in $Iterable [3].

Expected behaviour

No flow errors.

Your Environment

software	version
flow-bin	0.98.0

satya164 commented 5 years ago

Ideally I want to migrate the library to use TypeScript since Flow keeps breaking every release of React Native, so I don't want to spend energy fixing issues with Flow.

satya164 commented 5 years ago

Just migrated the lib to TypeScript. Closing since I don't use Flow anymore.