Pressing Refresh doesn't change anything when not Linked

satyagraha / gfm_viewer

An Eclipse plugin providing an accurate view of GitHub Flavored Markdown (.md) files

94 stars 27 forks source link

Pressing Refresh doesn't change anything when not Linked #46

Closed paulvi closed 10 years ago

paulvi commented 10 years ago

edited README is opened, GFM View is active, Linked mode off

Pressing Refresh doesn't change anything: no progress indicator, no indication of download starting in Console

satyagraha commented 10 years ago

It appears this happens in the situation when no HTML file has ever been displayed in the browser, which can happen when Linked mode is off.

I'll look into how to fix this in due course.

satyagraha commented 10 years ago

Unless at least one HTML file has been displayed in the GFM View, it can't know what to do.

Therefore I am not proposing to do anything about this at present.

You can make an enhancement request if you like, explaining the use case in detail.

satyagraha commented 10 years ago

What could work is as follows:

if the Reload button is pressed
and if no file has been shown in the browser
and if the currently active editor is editing a markdown file
then if Online the corresponding HTML will be generated if necessary (i.e. only if not up-to-date) and displayed in the browser
if Offline and no existing HTML then then no action is possible

paulvi commented 10 years ago

What is so simple for user becomes logic chain in software ...
And yes, that would make user experience more natural.
Hopes that never break in NPE under any circumstances ;-)

Maybe what is needed for some situations is to show something inside View, like saying

nothing to display current time 17:36:00

so user knows that his requests were processed...

satyagraha commented 10 years ago

Now implemented in develop, will go into release 1.8.2 in due course.

paulvi commented 10 years ago

BTW, I am releasing Nodeclipse 0.10 today.

satyagraha commented 10 years ago

Released.