Improve error message in parser.

satyasuman / diezel

Automatically exported from code.google.com/p/diezel

0 stars 0 forks source link

Improve error message in parser. #8

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?

When one forgets to include a transition tag for a token in the XML definition.

What is the expected output? What do you see instead?

Crashes with a null pointer exception. Would be nice to show a more specific 
error message, otherwise a typo will result in null ptr exception. Can be hard 
to find the bug.

What version of the product are you using? On what operating system?

beta-3

Please provide any additional information below.

Original issue reported on code.google.com by leoneume...@gmail.com on 6 Feb 2012 at 10:21

GoogleCodeExporter commented 9 years ago

Solution : provide post-XML-parsing Validation:
the expression syntax should be checked ( for correctness)
transition definition in "expression" and transition in XML should be matched ( 
extra transition resulting in a Warning)

Original comment by e...@ericaro.net on 6 Feb 2012 at 10:28

Changed state: Accepted
Added labels: Priority-High
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

Original comment by e...@ericaro.net on 6 Feb 2012 at 11:42

Changed state: Started

GoogleCodeExporter commented 9 years ago

This issue was closed by revision f76e040c361c.

Original comment by e...@ericaro.net on 7 Feb 2012 at 12:09

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Hi leo, please verifiy the bug fix. (don't knwow if you have the right to do 
so, but feel free to ask for them).

I've got a jenkins/CI that build the alpha-4-SNAPSHOT, it's available 5 min 
after the push in the sonatype snapshot depot: 
http://oss.sonatype.org/content/repositories/snapshots/

Original comment by e...@ericaro.net on 7 Feb 2012 at 12:12