search

satyrnidae / wolf-armor-and-storage-legacy

Minecraft mod that improves vanilla wolves, no custom entities required.
https://minecraft.curseforge.com/projects/wolf-armor-and-storage
MIT License
12 stars 8 forks source link

[3.7.5-1.12.2] crash on startup with sophisticated wolves. #178

Closed xelotex closed 2 years ago

xelotex commented 3 years ago

Issue Description A clear and concise description of the issue.

Relevant Mods A list or a link to a list of other mods relevant to the issue.

Reproduction Steps Steps to reproduce the behavior:

  1. Go to '...'
  2. Interact with '....'
  3. Place '....'
  4. See error

Expected Behavior A clear and concise description of what you expected to happen.

Screenshots / Videos If applicable, add screenshots or videos to help explain your problem.

Version Information:

crash-2021-02-07_11.55.39-client.txt

satyrnidae commented 3 years ago

Known issue with Sophisticated Wolves; it is using an outdated API. See https://github.com/NightKosh/Sophisticated-wolves/pull/90

xelotex commented 3 years ago

Known issue with Sophisticated Wolves; it is using an outdated API. See NightKosh/Sophisticated-wolves#90

wait, ¿what do i need to do to fix this issue?

satyrnidae commented 3 years ago

unfortunately until that linked pull request is accepted and a new version is released, Sophisticated Wolves and Wolf Armor and Storage are not currently compatible

xelotex commented 3 years ago

unfortunately until that linked pull request is accepted and a new version is released, Sophisticated Wolves and Wolf Armor and Storage are not currently compatible

it's not compatible with the latest versions of wolf armor (or upside down) but there's any old version of your mod that could be compatible with sophisticated wolves?

satyrnidae commented 3 years ago

any v2 release should work (file will be named like wolfarmor-1.12.2-2.x.x.x). These versions aren't supported any longer, but they may work

xelotex commented 3 years ago

any v2 release should work (file will be named like wolfarmor-1.12.2-2.x.x.x). These versions aren't supported any longer, but they may work

thanks

CovertJaguar commented 3 years ago

Actually, after compiling the PR myself, the game still crashes with this error.

I suspect it related to this code: https://github.com/satyrnidae/wolfarmor/blob/master/src/main/java/dev/satyrn/wolfarmor/compatibility/sophisticatedwolves/SophisticatedWolvesProvider.java

CovertJaguar commented 3 years ago

For reference, I can confirm that running Sophisticated Wolves 3.13.9 (with the Wolf Armor compat code stripped) works flawlessly with Wolf Armor 3.4.1.1. Pet Carrier works, treats work, everything seems to work.

Contrast that to version 3.7.5 of Wolf Armor, which crashes on startup with any version of SW.

satyrnidae commented 2 years ago

Additional investigation revealed that the entire compatibility layer wasn't working right on servers or with sophisticated wolves at all. Should be fixed presently.

satyrnidae commented 2 years ago

Fixed by 73e2081 and ceaf9bd