Open alexiglesias31 opened 12 months ago
I didn't know about that, yes, I tested with an empty string and works as well 👍
P.D: 🤔, giving a second thought to this, it doesn't feel correct to me that the estimated order amount is empty when the currency is different. I would find more intuitive to pass the converted amount rather than an empty string.
Providing a new approach, instead of set the total as empty, moving back to return an empty string on the estimated_order_amount, but now adding some checks in the JS code so the parameter is not set when is empty.
@dpanta94 asking CR again, since the EOA was still being calculated on blocks.
I think so 😄, EOA is not used on the JS related to classics
All Submissions:
Changes proposed in this Pull Request:
Disable the estimated order amount if the currency is not the default currency for the region.
How to test the changes in this Pull Request:
FOX - Currency Switcher Professional for WooCommerce
.Other information:
Changelog entry