search

saucecontrol / PhotoSauce

MagicScaler high-performance, high-quality image processing pipeline for .NET
http://photosauce.net/
MIT License
569 stars 49 forks source link

add net8.0 target framework on Native Codecs project #144

Closed pvoliveira closed 6 months ago

pvoliveira commented 6 months ago

This PR enables the target net8.0 for the Native Codecs project.

After compiling the project locally, I added the reference and things started to work again.

Issue related: https://github.com/saucecontrol/PhotoSauce/issues/143

saucecontrol commented 6 months ago

@pvoliveira I appreciate your interest in contributing, but to be quite honest, this is not a good PR.

Your issue #143 amounts to nothing more than "I had a problem", and your PR description is no better than "I tried this random thing, and my problem went away".

It is not obvious to me how a 'missing' net8.0 target on the codec packages would cause any kind of issue. My guess would be you simply had a transient package restore failure in VS after updating your app's TFM, which is usually solvable with a rebuild or with a dotnet restore.

NuGet packages automatically support a newer TFM, so the net7.0-targeted codec packages will restore in net8.0 apps. You can see this on the package's frameworks tab, where the presence of the net8.0 TFMs indicates that the package is compatible with them.

For reference, #96 was a good PR in a similar area. Notice how it explains precisely what the problem is and how the change fixes that problem.

I'm going to close this for now. If you have any additional repro steps or explanation of why you think a change is necessary, please add them to the issue.

@andrecoutosilva I see you gave this a thumbs up. If you have any context to add, can you please comment on #143 as well?