search

saucecontrol / PhotoSauce

MagicScaler high-performance, high-quality image processing pipeline for .NET
http://photosauce.net/
MIT License
589 stars 49 forks source link

Align extension TFMs with main lib to prevent build feature mismatch. #96

Closed Sewer56 closed 2 years ago

Sewer56 commented 2 years ago

This fixes extensions (libjxl, libpng etc.) in netcoreapp3.1 & net5.0 runtimes. (I verified this manually inside dummy project).

Previously, when using these runtimes, a version of libjxl would be picked that doesn't natively support spans (NS2.0) and one that does for main library (netcoreapp3.1), leading to the extension trying to call stream extension method(s) that don't exist in the main library. [i.e. mismatched native span support define]

This PR simply changes the .csproj such that the extension TFMs match the main project's TFMs, under both default and dist configuration.

saucecontrol commented 2 years ago

Thanks! Would you mind updating the other native codec projects the same way? They'll all be using the Stream extension methods and will have the same issue. I'd prefer to get them all updated in the same commit.

Sewer56 commented 2 years ago

Yeah no problem, let me get on that.

Sewer56 commented 2 years ago

Alright, should be good 👍

saucecontrol commented 2 years ago

Thanks again!