saucelabs / bamboo_sauce

Bamboo plugin for use with Sauce OnDemand
11 stars 5 forks source link

Dockerize. Special libertym build. #44

Closed richard-sl closed 2 years ago

richard-sl commented 7 years ago

@saucy-aseem @halkeye - Please review.

I am not sure we want to merge this whole thing in its entirety, but I think we should keep all this libertym stuff together.

halkeye commented 7 years ago

All the .java files can probably be ignored.

I'm not a fan of docker for this sort of thing, but I guess it's totally optional anyways

halkeye commented 7 years ago

Also I think .78 might have already been released. Should be .79 snapshot

richard-sl commented 7 years ago

All the .java files can probably be ignored.

I'll try omitting:

# Copy Maven preference files to predefine the command line question about # subscribing to the mailing list to `NO`. 
COPY .java /root/.java

From the Dockerfile to check that nothing blows up.

I'm not a fan of docker for this sort of thing, but I guess it's totally optional anyways

I'm curious to know where you're coming from there. I think it'll save folk a bunch of time from setting up a local development environment manually, and helps guard against inadvertently installing different versions of the environmental dependencies.

halkeye commented 7 years ago

I'm curious to know where you're coming from there. I think it'll save folk a bunch of time from setting up a local development environment manually, and helps guard against inadvertently installing different versions of the environmental dependencies.

Mostly because it'll complicate IDEs because the deps will no longer be installed, so it can't really check import statements or auto complete or anything else.

richard-sl commented 7 years ago

Mostly because it'll complicate IDEs because the deps will no longer be installed, so it can't really check import statements or auto complete or anything else.

Good point. That's hella annoying. Do you think some reverse mounts from within the container back out to the working directory would be good enough for the IDE's then?

richard-sl commented 7 years ago

All the .java files can probably be ignored. I'll try omitting ... [.java]

selection_008

Without the .java XML's the atlas-* commands can result in an annoying prompt that'll block further automation. I don't think they can be ignored? Or were you thinking of something else?

codecov-io commented 7 years ago

Codecov Report

Merging #44 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #44   +/-   ##
=========================================
  Coverage     30.98%   30.98%           
  Complexity       65       65           
=========================================
  Files            16       16           
  Lines           752      752           
  Branches         96       96           
=========================================
  Hits            233      233           
  Misses          480      480           
  Partials         39       39

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a67e1e...e54307a. Read the comment docs.

maciejurbanskisaucelabs commented 2 years ago

Not merger for so long, so it's not needed ;p