http_proxy: remove ambiguity in connect headers configuration

saucelabs / forwarder

Forwarder is a production-ready, fast MITM proxy with PAC support. It's suitable for debugging, intercepting and manipulating HTTP traffic. It's used as a core component of Sauce Labs Sauce Connect Proxy.

https://forwarder-proxy.io

Mozilla Public License 2.0

202 stars 13 forks source link

http_proxy: remove ambiguity in connect headers configuration #782

Closed mmatczuk closed 2 months ago

mmatczuk commented 2 months ago

This is a small refactoring that would remove the ambiguity in Martian configuration.

Plan:

Wrap header modifier in a layer that checks the HTTP method, for CONNECT use proxyHeaders, otherwise use requestHeaders
Remove ConnectRequestModifier in HTTPProxyConfig, martian.Proxy and dialvia
Add ProxyConnectHeader in dialvia and set it in Martian