search

saucelabs / sauce-java

A set of helpers for consuming Sauce Labs services from Java
Apache License 2.0
45 stars 61 forks source link

Test update #76

Open joshgrantsauce opened 5 years ago

joshgrantsauce commented 5 years ago

Small updates for removing connections to Sauce Labs in existing unit tests for SOL-13. Also added some possible structure for acceptance tests that do in fact connect to Sauce Labs.

nadvolod commented 5 years ago

Hey @joshgrantsauce I'm close to finishing this branch here: https://github.com/saucelabs/sauce-java/blob/js2/common/src/test/java/com.saucelabs.common/SauceHelperAcceptanceTest.java

And it pretty much overwrites all that you did in this PR. How do you want me to handle it. Our naming conventions are a little different, but I think we had the same idea. Do you want me to merge our branches and rename something? Or should I just PR my branch and we close this one?

joshmgrant commented 5 years ago

@nikolay-advolodkin you're farther along than I am, which is great! I'd say merge your changes and I'll either decline or update this PR as needed.