Make public getSauceUsernamee() and getSauceAccessKey()

[nadvolod]

I'm trying to use these methods in one of my tests to read the values but they are private. A hinderance to users I believe.

    private String getSauceUsername() {
        if (this.getSystemProperty("SAUCE_USERNAME") != null) {
            return this.getSystemProperty("SAUCE_USERNAME");
        } else if (this.getEnvironmentVariable("SAUCE_USERNAME") != null) {
            return this.getEnvironmentVariable("SAUCE_USERNAME");
        } else {
            throw new SauceEnvironmentVariablesNotSetException("Sauce Username was not provided");
        }
    }

    private String getSauceAccessKey() {
        if (this.getSystemProperty("SAUCE_ACCESS_KEY") != null) {
            return this.getSystemProperty("SAUCE_ACCESS_KEY");
        } else if (this.getEnvironmentVariable("SAUCE_ACCESS_KEY") != null) {
            return this.getEnvironmentVariable("SAUCE_ACCESS_KEY");
        } else {
            throw new SauceEnvironmentVariablesNotSetException("Sauce Access Key was not provided");
        }
    }

[titusfortner]

I thought we decided that was a feature, not a bug since it was going to be all handled by ENV.

you could just do: System.getEnv("SAUCE_USERNAME")

What is the use case for getting it? We should be abstracting everything you can do with it...

[nadvolod]

@titusfortner I think the Set can be private. But the Get can be public. Use Cases:

• I am using Sauce Bindings for mobile which doesn't work 100%. As a work around, I wanted to use the getSauceAccessKey() and getSauceUsername() to configure my mobile caps, but couldn't. Yes, I could do this System.getEnv("SAUCE_USERNAME"), but why when it's already inside one of our objects?
• What if someone just wanted to read the values from getSauceAccessKey() and getSauceUsername()? Maybe for reporting purposes?