search

saucelabs / sauce_bindings

Making test automation with Sauce Labs insanely simple
https://saucelabs.github.io/sauce_bindings
MIT License
23 stars 16 forks source link

Capture Performance vs Test Name #267

Open titusfortner opened 3 years ago

titusfortner commented 3 years ago

Right now Java errors if capture performance is set without setting test name, but with the test runners this is set automatically after the session is created, requiring users to set it. We should remove the check in the setter and put it in the capability conversion method.

nadvolod commented 2 years ago

@titusfortner we should fix this bug, our current Performance example is weird as it's really tough to set a good test name per test as it's implemented in. 

   @Override
    public SauceOptions createSauceOptions() {
        return SauceOptions.chrome()
                .setExtendedDebugging()
                .setName("PerformanceTest") // bug - https://github.com/saucelabs/sauce_bindings/issues/267
                .setCapturePerformance()
                .build();
    }

I didn't take a long look, not sure if you know of a work around?