search

saucelabs / sauce_whisk

ActiveRecord style client for the Sauce Labs RESTful API
https://opensource.saucelabs.com/sauce_whisk/
MIT License
20 stars 17 forks source link

Travis isn't running the tests #19

Closed bootstraponline closed 10 years ago

bootstraponline commented 10 years ago

https://travis-ci.org/DylanLacey/sauce_whisk/builds

Is sauce_whisk still maintained? The CI hasn't run in 8 months. In addition, the test command it used is broken.

bundle exec rake

That doesn't even run the tests.

jlipps commented 10 years ago

I think sauce_whisk is now a part of the saucelabs account: https://travis-ci.org/saucelabs/sauce_whisk/builds

bootstraponline commented 10 years ago

It's still not running the tests on Travis. There's no output.

I'll submit a PR to fix the readme link to point to the new location. #20

bootstraponline commented 10 years ago

There's also no .travis.yml file which is triggering a warning.

bootstraponline commented 10 years ago

50 failures on Travis now that the Rakefile is working. I hoped to recommend this gem in the appium training. It doesn't look like that makes sense until the tests pass.

bootstraponline commented 10 years ago

It looks like Travis will never run the Sauce tests for pull requests from forks.

If your build relies on these to run, for instance to run Selenium tests with Sauce Labs, your build needs to take this into account. You won't be able to run these tests for pull requests from external contributors.

Edit: vcr should enable the tests to run without making real HTTP requests.

bootstraponline commented 10 years ago

Added a .travis.yml in #21 and Travis is down to 11 failures instead of 50. This matches what I'm seeing locally.

DylanLacey commented 10 years ago

I removed the .travis.yml, I believe because there was nothing actually in it that was useful (as VCR had mocked out all the external requests).

I'm investigating the test failures ATM. They're not happening locally, so I'm suspicious of either mocking or possibly a version issue.

bootstraponline commented 10 years ago

I removed the .travis.yml, I believe because there was nothing actually in it that was useful (as VCR had mocked out all the external requests).

I think at a minimum, you want to have Travis run the tests on Ruby 1.9 and 2.1. That can't be done without a .travis.yml file. It's fixed now that #21 is merged.

DylanLacey commented 10 years ago

Yeah, that's a good point. At the time I was just looking at 1.9.3

On Sun, Mar 30, 2014 at 8:23 PM, bootstraponline notifications@github.comwrote:

I removed the .travis.yml, I believe because there was nothing actually in it that was useful (as VCR had mocked out all the external requests).

I think at a minimum, you want to have Travis run the tests on Ruby 1.9 and 2.1. That can't be done without a .travis.yml file. It's fixed now that

21 https://github.com/saucelabs/sauce_whisk/pull/21 is merged.

Reply to this email directly or view it on GitHubhttps://github.com/saucelabs/sauce_whisk/issues/19#issuecomment-39051142 .

Dylan Lacey Developer Evangelist Sauce Labs Inc @dylanlacey http://www.twitter.com/dylanlacey

Reading from the Book of Ruby? Want to test your site or mobile app against over 270 Browser/OS and Platform combos without having to provision a single machine? Hit me up.