search

saucelabs / the-internet

An example application that captures prominent and ugly functionality found on the web. Perfect for writing automated acceptance tests against.
http://the-internet.herokuapp.com
Apache License 2.0
787 stars 648 forks source link

Update frame_bottom.erb #10

Closed djangofan closed 10 years ago

djangofan commented 10 years ago

Updated frame_bottom.erb to have an example of an iFrame within the /frames URI. Please modify to suite the usage. I am only making a suggestion here that is testable by a Selenium script by having a hyperlink that opens a new window.

Keep in mind that if a Selenium script actually clicks the link to open the new window, the browser instance will end up having an array of 7 windows I think: default, left, right, middle, bottom, iframe, and new_window. Is this correct?

tourdedave commented 10 years ago

Thanks for the pull request! And apologies for the delay. Here's where I ended up:

I reverted the frame bottom change in favor of making the nested frames example more explicit. I broke things out into three views (/frames /nested_frames and /iframe). /frames links to /nested_frames and /iframe.

With your HTML4 iframe example I tried it in it's own view but had trouble rendering the link on the page. That, and it felt like there needed to be more meat to demonstrate an iframe. So I used the TinyMCE iframe view instead.

Cheers, Dave H

djangofan commented 10 years ago

Thanks. After I commited I gave up on it because my first try failed. I don't completely understand your web framework. Glad you were able to revive it. Thanks.