Closed califrench closed 8 years ago
@califrench thanks, but I don't think that it's great idea. We should stick with Optional Chaining.
@sauliusgrigaitis Okay I'll update the code to use optional chaining instead just as in my second example
@califrench probably we can go with this solution for now. Please make one commit. And add test :)
@sauliusgrigaitis Done! Hopefully the tests pass as I am not able to run them locally
@califrench please squash into one commit every time :)
Is there a GIT way to merge many commits into one?
Best,
Scott Gauthreaux Developer www.scottgauthreaux.com
On Mar 23, 2016, at 12:42, Saulius Grigaitis notifications@github.com wrote:
@califrench please squash into one commit every time :)
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub
The whole PR?
Best,
Scott Gauthreaux Developer www.scottgauthreaux.com
On Mar 23, 2016, at 12:42, Saulius Grigaitis notifications@github.com wrote:
@califrench please squash into one commit every time :)
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub
@califrench please check latest code - you now can run tests on OSX!!!!!!!11!!!!!!!!1!!!!111 Please rebase your PR against latest master.
Hi @sauliusgrigaitis thanks for the link and I'll do ASAP. Stoked about the 2.2 release in XCode and our migration over to XCTest
This adds support for the
mimeType()
function onString?
types. The previous implementation allowed to pass nil values to the internalMimeType(ext: String?) -> String
function but.mimeType()
could never be called on a nil String because that was an extension on theString
type. This allows us to do thisInstead of this
Or worse
This new implementation is used in the router and fixes #25