saulmm / CoordinatorBehaviorExample

2.71k stars 590 forks source link

Scrolling issue #8

Closed EpsilonOrionis closed 8 years ago

EpsilonOrionis commented 9 years ago

I'm including a custom layout into the CardView, but it's short and when I scoll the view, I get a wide void space between the toolbar and the CardView. Could you block the animation when the scrolling is terminated?

Thanks in advance

P.S: Sorry for my bad English.

nishantBabaria commented 9 years ago

Add android:clickable="true" to CardView For Scrolling Like Google Play Profile

<android.support.v7.widget.CardView android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_margin="8dp" app:cardElevation="8dp" app:contentPadding="16dp" android:clickable="true"

MedoElkamaly commented 8 years ago

great @nishantBabaria it works like a charm :+1:

saulmm commented 8 years ago

There is a new layout_scrollFlag that animates the AppbarLayout from an specific percentage of scroll, I can't reproduce that bug, could you @EpsilonOrionis check now with the new support libraries version?

Thanks!

EpsilonOrionis commented 8 years ago

The problem is still alive. I just want to scroll and when everthing is visible, block the scrolling. It continues that's the problem. The actual behavior is good because of the length of the TextView contained in the CardView, but if our CardView isn't so big it will scroll creating a wide gap between the CardView and the bottom of our screen.

saulmm commented 8 years ago

@EpsilonOrionis could you take a video of the bug to check what's happening?

EpsilonOrionis commented 8 years ago

I don't think it's a bug. You can try it. You have to make the CardView shorter, for example with a short word in the TextView inside it. Try to scroll and look what happens... It's wrong. It should block the scroll when the hole CardView and thus it's content is fully visible.

EpsilonOrionis commented 8 years ago

Please answer...

saulmm commented 8 years ago

@EpsilonOrionis sorry for the delay, will give you an answer soon ;)

EpsilonOrionis commented 8 years ago

Ok, thank you :)

saulmm commented 8 years ago

I saw your bug, will take care in a new release