search

saulmm / Material-Movies

[Deprecated] An application about movies with material design
Apache License 2.0
2.43k stars 613 forks source link

Domain and Model modules vs business logic module #3

Open pedrovgs opened 9 years ago

pedrovgs commented 9 years ago

Hi Saul! Thanks for your time to prepare this article and this repository!!

I'd like to comment some things to know your opinion:

In this article you use "domain" and "model" as a separated concept when most of the authors use "domain model" to talk about all the classes related to your business logic and abstractions needed to model the problem. Your "model" module is used to retrieve data from an external API and you comment that in the future will be used to persist data. The responsibility of this "model" module is more related to a repository or two different modules like one api client and one storage. In addition, I see your class TvMovie created in your "model" module is used from your "app" module, doing this you are coupling your "app" and "domain" module to the code related to the API Client and the persistence. Don't you prefer to move that entities to your business logic layer. What do you think?

olegflo commented 9 years ago

Subscribed to your discussion, interesting to follow this.

when most of the authors use "domain model" to talk about all the classes related to your business logic and abstractions needed to model the problem

Could you please provide some authoritative references, would like to investigate deeper.

pedrovgs commented 9 years ago

Martin Fowler -> http://martinfowler.com/eaaCatalog/domainModel.html