Card (7d) still misaligned in Vertical4 sprite.png

[kheremos]

I noticed you had a PR where you updated the alignment of this problematic card. Unfortunately for me, I picked the image where it has not been corrected. I'm not sure if you're still keeping the repo up-to-date, and unfortunately I can't fix it and submit a PR because I'm without a dev machine at the moment...

Thanks for your work! Similar offerings had viral licenses...

https://github.com/saulspatz/SVGCards/blob/master/Decks/Vertical4/pngs/sprite.png

[saulspatz]

I haven't looked at this, or used inkscape, in a long time, but I'll be happy to try to fix it. It may take me a little while. If it hasn't been fixed in 7 days from today, please remind me.

On Wed, Sep 22, 2021 at 1:37 PM kheremos @.***> wrote:

I noticed you had a PR where you updated the alignment of this problematic card. Unfortunately for me, I picked the image where it has not been corrected https://github.com/saulspatz/SVGCards/blob/master/Decks/Vertical4/pngs/sprite.png. I'm not sure if you're still keeping the repo up-to-date, and unfortunately I can't fix it and submit a PR because I'm without a dev machine at the moment...

Thanks for your work! Similar offerings had viral licenses...

https://github.com/saulspatz/SVGCards/blob/master/Decks/Vertical4/pngs/sprite.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/saulspatz/SVGCards/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPKBPI4KF3RR4MSBFDXRD3UDIO5NANCNFSM5ER6QAGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[kheremos]

Thanks! I was just looking for a public domain spritesheet to use as a placeholder for a project I'm working on.. So, the following two have the 7d misalignment issue:

https://github.com/saulspatz/SVGCards/blob/master/Decks/Vertical2/gifs/sprite.gif https://github.com/saulspatz/SVGCards/blob/master/Decks/Vertical2/pngs/sprite.png https://github.com/saulspatz/SVGCards/blob/master/Decks/Vertical4/gifs/sprite.gif https://github.com/saulspatz/SVGCards/blob/master/Decks/Vertical4/pngs/sprite.png

But I can use [this one], so no rush. Both of the Horizontal options seem to be rendered correctly.

Also, have you considered red hearts, green clubs, blue diamonds and black spades? I believe that's actually an accessibility setting for a variety of poker applications (pokerstars among them). Sorry for such an annoying request, I really should set up a better environment for myself...

[kheremos]

And actually, looking closer at https://raw.githubusercontent.com/saulspatz/SVGCards/master/Decks/Vertical4/svgs/sprite.svg it looks like the 7d needs to be moved vertically by a pixel or two.

[saulspatz]

I did this for myself, because I couldn't find a deck that I liked for my own games. Once I got something I liked, I decided to share it, and I haven't looked at inkscape since. So, I don't know how much work changing the colors entails. I'm a retiree, with lots of time on my hands though, so I'm interested in any project. I'll look into it.

On Wed, Sep 22, 2021 at 2:31 PM kheremos @.***> wrote:

Thanks! I was just looking for a public domain spritesheet to use as a placeholder for a project I'm working on.. So, the following two have the 7d misalignment issue:

https://github.com/saulspatz/SVGCards/blob/master/Decks/Vertical2/pngs/sprite.png

https://github.com/saulspatz/SVGCards/blob/master/Decks/Vertical4/pngs/sprite.png

But I can use [this one https://github.com/saulspatz/SVGCards/blob/master/Decks/Horizontal4/pngs/sprite.png], so no rush. Both of the Horizontal options seem to be rendered correctly.

Also, have you considered red hearts, green clubs, blue diamonds and black spades? I believe that's actually an accessibility setting for a variety of poker applications (pokerstars among them). Sorry for such an annoying request, I really should set up a better environment for myself...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/saulspatz/SVGCards/issues/2#issuecomment-925257419, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPKBPPTJU6J5P5RNARXYRDUDIVHZANCNFSM5ER6QAGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[saulspatz]

I agree with you on the vertical4 sprite.

On Wed, Sep 22, 2021 at 2:38 PM Saul Spatz @.***> wrote:

I did this for myself, because I couldn't find a deck that I liked for my own games. Once I got something I liked, I decided to share it, and I haven't looked at inkscape since. So, I don't know how much work changing the colors entails. I'm a retiree, with lots of time on my hands though, so I'm interested in any project. I'll look into it.

On Wed, Sep 22, 2021 at 2:31 PM kheremos @.***> wrote:

Thanks! I was just looking for a public domain spritesheet to use as a placeholder for a project I'm working on.. So, the following two have the 7d misalignment issue:

https://github.com/saulspatz/SVGCards/blob/master/Decks/Vertical2/pngs/sprite.png

https://github.com/saulspatz/SVGCards/blob/master/Decks/Vertical4/pngs/sprite.png

But I can use [this one https://github.com/saulspatz/SVGCards/blob/master/Decks/Horizontal4/pngs/sprite.png], so no rush. Both of the Horizontal options seem to be rendered correctly.

Also, have you considered red hearts, green clubs, blue diamonds and black spades? I believe that's actually an accessibility setting for a variety of poker applications (pokerstars among them). Sorry for such an annoying request, I really should set up a better environment for myself...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/saulspatz/SVGCards/issues/2#issuecomment-925257419, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPKBPPTJU6J5P5RNARXYRDUDIVHZANCNFSM5ER6QAGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[kheremos]

And I hope this ticket isn't bothersome for you. I really appreciate your work.

I don't know how much you enjoy coding or poker analysis, but might I recommend this cool article by Keith Rule?

[saulspatz]

Thanks. I enjoy coding, but I'm not interested in poker. I looked at the project, and I see that I have a python script for automatically changing the suit colors, so I think I can promise to do that, at least for the individual cards. Not sure about the sprite sheets yet. If I remember correctly, I had a lot of trouble making them in the first place, and things get harder for me with each passing year. I'll certainly give it a try if the color change works as expected.

On Wed, Sep 22, 2021 at 2:47 PM kheremos @.***> wrote:

And I hope this ticket isn't bothersome for you. I really appreciate your work.

I don't know how much you enjoy coding or poker analysis, but might I recommend this cool article by Keith Rule https://www.codeproject.com/Articles/12279/Fast-Texas-Holdem-Hand-Evaluation-and-Analysis ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/saulspatz/SVGCards/issues/2#issuecomment-925275868, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPKBPKIA5WTWXX34KQX45LUDIXG5ANCNFSM5ER6QAGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[saulspatz]

Hi,

I think I've got everything we talked about done. I'm not terribly happy with the coloring job on the accessible decks, but I did my best.

Please let me know of any problems or omissions.

Saul

On Wed, Sep 22, 2021 at 3:14 PM Saul Spatz @.***> wrote:

Thanks. I enjoy coding, but I'm not interested in poker. I looked at the project, and I see that I have a python script for automatically changing the suit colors, so I think I can promise to do that, at least for the individual cards. Not sure about the sprite sheets yet. If I remember correctly, I had a lot of trouble making them in the first place, and things get harder for me with each passing year. I'll certainly give it a try if the color change works as expected.

On Wed, Sep 22, 2021 at 2:47 PM kheremos @.***> wrote:

And I hope this ticket isn't bothersome for you. I really appreciate your work.

I don't know how much you enjoy coding or poker analysis, but might I recommend this cool article by Keith Rule https://www.codeproject.com/Articles/12279/Fast-Texas-Holdem-Hand-Evaluation-and-Analysis ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/saulspatz/SVGCards/issues/2#issuecomment-925275868, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPKBPKIA5WTWXX34KQX45LUDIXG5ANCNFSM5ER6QAGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[kheremos]

Looks great. Will import the green PNG into my app and see if everything lines up. Thanks!

[luiscastro193]

These are great, thanks for the good work. I made a little memory game with these cards. However, the 7 of diamonds I'm using is still misaligned:

https://github.com/saulspatz/SVGCards/blob/master/Decks/Vertical2/svgs/diamond7.svg

[saulspatz]

Do you mean that the rectangle containing the seven diamond pips isn't centered correctly?

On Fri, Jan 14, 2022 at 3:55 PM Luis Castro Martín @.***> wrote:

These are great, thanks for the good work. I made a little memory game https://luiscastro193.github.io/memory/ with these cards. However, the 7 of diamonds I'm using is still misaligned:

https://github.com/saulspatz/SVGCards/blob/master/Decks/Vertical2/svgs/diamond7.svg

— Reply to this email directly, view it on GitHub https://github.com/saulspatz/SVGCards/issues/2#issuecomment-1013499817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPKBPKBMM5TGBQFHPN4JRTUWCLUZANCNFSM5ER6QAGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

[luiscastro193]

Yes, exactly

[saulspatz]

Thanks. I'll try to fix it. I may not get to it until sometime next week.

On Fri, Jan 14, 2022 at 4:32 PM Luis Castro Martín @.***> wrote:

Yes, exactly

— Reply to this email directly, view it on GitHub https://github.com/saulspatz/SVGCards/issues/2#issuecomment-1013518050, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPKBPJBIKZXVN7VPX3A3CDUWCQBBANCNFSM5ER6QAGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

[luiscastro193]

Great, thanks!

[saulspatz]

Should be fixed for all decks now, for sprites, and individual cards, both SVGs and PNGs. Let me know if I've missed anything, please.

[luiscastro193]

It's perfect now, thanks a lot!

[saulspatz]

You;ew welcome. Thanks again for pointing out the problem.

On Thu, Jan 20, 2022 at 12:01 PM Luis Castro Martín < @.***> wrote:

It's perfect now, thanks a lot!

— Reply to this email directly, view it on GitHub https://github.com/saulspatz/SVGCards/issues/2#issuecomment-1017773574, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPKBPK2JOUTZJMO4RGPC2TUXBEX5ANCNFSM5ER6QAGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you modified the open/close state.Message ID: @.***>