search

saurabhd / hk_realestate

GNU General Public License v2.0
1 stars 0 forks source link

#touch Prevent keyboard on search selects #15

Closed heliogabal closed 8 years ago

heliogabal commented 8 years ago

When I look at the mobile and tablet version, once I try to select something from the search box, the OS keyboard opens, even though I don't need it and it overlays the form. Makes it really hard to select something.

So please find a way to prevent the keyboard from showing up when searching. Of course it has to come up when making an inquiry or filling out the contact form. I found several solutions on stackoverflow, either using blur or deselected on the input fields, so it should be possible either with JS or hook_form_alter. Not sure what the best solution is.

darshi-shah commented 8 years ago

Hi Rainer,

I tried checking this on http://addweb.dev.drupalforgood.eu but search is not working on this properly on mobile device for this. Let me know on which site I can check this.

Thanks, Darshi

heliogabal commented 8 years ago

Hi Darshi, I did a git pull yesterday there but didn't check, so right now js is not working. I'll check and let you know once it's working again.

heliogabal commented 8 years ago

Hi Darshi,

now you can check. I cleaned up too much on my latest commit, readded now. Sorry for the delay.

darshi-shah commented 8 years ago

Thanks Rainer

darshi-shah commented 8 years ago

Hi Rainer,

js is added for this. Also, Search toggle effect that we added previously was removed so added that back as well.

Let us know once this is up on staging site so we can check there.

Thanks Darshi

heliogabal commented 8 years ago

Hi Darshi,

it's pulled, but I think you have to add some prevent default to the js, otherwise, the dummy-link is followed. I can't see the inputs at all, only the box is toggled.

darshi-shah commented 8 years ago

Hi Rainer,

prevent default is added in js.

Thanks Darshi

heliogabal commented 8 years ago

Hi Darshi,

Ok thanks, so now we stay on the page when toggling the search. The initial issue is still kind of pending? Is the readonly attribute reliable on different platforms? As I said before, on my mobile Chrome I don't see the inputs, so I can't check. Is it supposed to be working yet?

vivek-addweb commented 8 years ago

Hi Rainer

Issue is resolved for mobile view. You will be able to see input fields now.

heliogabal commented 8 years ago

great, it's working now! ... at least for the homepage. On buy, I don't get any search box to toggle... is it only me?

vivek-addweb commented 8 years ago

Hi Rainer Issue is resolved for mobile view on Buy page.