saurabhd / hk_realestate

GNU General Public License v2.0
1 stars 0 forks source link

Computed field: allocable + not allocable incidental cost = incidental cost #43

Closed heliogabal closed 7 years ago

heliogabal commented 7 years ago

We already have two fields field_apart_alloc_incident_costs and field_apart_nalloc_incid_cost that should be combined in a third field (sum of both fields) incidental_cost that should be visible in the apartment details.

darshi-shah commented 7 years ago

Hi Rainer,

This is done and pushed in develop branch. Please revert hk_ct feature.

Thanks Darshi

heliogabal commented 7 years ago

Hi Darshi, looks almost ready. Just rename the label to Incidental Cost instead of Apartment Incidental Cost, and hide the field if it is empty (no 0 €/month). Then it is good to go.

darshi-shah commented 7 years ago

Hi Rainer,

This is done and pushed on develop branch. Should we also hide Allocable incidental costs and Not allocable incidental costs fields as well if they have 0 value ?

Thanks Darshi

heliogabal commented 7 years ago

Hi Darshi, I thought they were already hidden when empty, but I was wrong. Yes, also hide those if they're empty.

darshi-shah commented 7 years ago

Hi Rainer,

Allocable incidental costs and Not allocable incidental costs both allows negative values. Should we show them?

Thanks Darshi

heliogabal commented 7 years ago

Hi Darshi,

No, there can't be negative values in these fields, so just show the ones >0. Must have been an oversight when creating these fields.

Thanks, Rainer

darshi-shah commented 7 years ago

Hi Rainer,

These changes are pushed on develop.

Thanks Darshi

heliogabal commented 7 years ago

Hi Darshi, I thought they were already hidden when empty, but I was wrong. Yes, also hide those if they're empty.