search

saurabhdaware / text-to-handwriting

So your teacher asked you to upload written assignments? Hate writing assigments? This tool will help you convert your text to handwriting xD
https://saurabhdaware.github.io/text-to-handwriting/
MIT License
4.74k stars 1.14k forks source link

Fixed contributors card responsive issue. #40

Closed kasipavankumar closed 4 years ago

kasipavankumar commented 4 years ago

Hello, boss!

I've fixed few issues which I think might improve the site usage.

What have I fixed?

  1. Added target="_blank" attribute to two of the <a> tags in index.html so that the links open in new tab & users won't leave your website.
  2. I found a responsiveness issue with the contributors card at width less than 768px & was able to fix it with some CSS. Below are the images about the issue.
  3. A tiny correction in spelling from CONTRUBUTING.md to CONTRIBUTING.md in index.html.

Issue: contributors_card_issue

After fixing: contributors_card_issue_fixed

Thank you.

netlify[bot] commented 4 years ago

Deploy preview for text-to-handwriting processing.

Building with commit 0d3647a9cefc67e274298458098aae04e93533fc

https://app.netlify.com/sites/text-to-handwriting/deploys/5ed64c8b91c1430006423869

kasipavankumar commented 4 years ago

Got it, boss. I read that article & understood where and where not to use the target="_blank". Will make the necessary changes and get back.

Thank you.

kasipavankumar commented 4 years ago

I have removed the target attributes, boss.

Thank you.