search

saurabhdaware / text-to-handwriting

So your teacher asked you to upload written assignments? Hate writing assigments? This tool will help you convert your text to handwriting xD
https://saurabhdaware.github.io/text-to-handwriting/
MIT License
4.71k stars 1.13k forks source link

added medium editor for headings ... and photos #47

Closed aneesijaz closed 4 years ago

aneesijaz commented 4 years ago

well I was doing y assignment and the thing I missed most was to add headings in there and also the images of graphs which I had drawn on copy and then picked up via photoshop as pngs. (I had to manually convert the graph images to data URIs to add into the editor.)..

So just added the medium editor with photos plugin ... which solves both issues adding your own photos from pc. as well adding heading of three different levels.

ezgif-4-c477c58c0544

netlify[bot] commented 4 years ago

Deploy preview for text-to-handwriting processing.

Building with commit a27345b87168ccd17db07a02b8597055c9e1238e

https://app.netlify.com/sites/text-to-handwriting/deploys/5ee29edf6f0e6c00088143ca

saurabhdaware commented 4 years ago

Hi there, this is cool but may I know the reason why you would need heading? I had this idea initially but dropped it because think of this situation:

If I am writing assignment and I feel like headlining something, my pen won't magically start writing in bold so I don't really feel this feature makes sense for this particular project as it will just make the image look less real. (If you still need to bold text, you can select text and press CTRL + B)

Additionally, jQuery is probably an overkill for this feature since it will slow down the website plus we don't really need it for any other feature, This is the current performance report: Performance Report that shows 94 performance score

This is report of deploy preview of this PR: Performance Report that shows 61 performance score

Thanks and let me know your thoughts

aneesijaz commented 4 years ago

well we could use a marker while writing assignment... most of the time I use marker for headings which make the text a little bit bold and bigger for headings...

and yestm I thought about removing jQuery but the medium editor does not have any vanilla js api so I couldn't.

On Sun, Jun 14, 2020, 8:29 PM Saurabh Daware notifications@github.com wrote:

Hi there, this is cool but may I know the reason why you would need heading? I had this idea initially but dropped it because think of this situation:

If I am writing assignment and I feel like headlining something, my pen won't magically start writing in bold so I don't really feel this feature makes sense for this particular project as it will just make the image look less real. (If you still need to bold text, you can select text and press CTRL + B)

Additionally, jQuery is probably an overkill for this feature since it will slow down the website plus we don't really need it for any other feature, This is the current performance report: [image: Performance Report that shows 94 performance score] https://user-images.githubusercontent.com/30949385/84597272-8f36c680-ae80-11ea-9ad6-703a9be1a6a6.png

This is report of deploy preview of this PR: [image: Performance Report that shows 61 performance score] https://user-images.githubusercontent.com/30949385/84597327-df158d80-ae80-11ea-855e-3eb2141be2e2.png

Thanks and let me know your thoughts

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/saurabhdaware/text-to-handwriting/pull/47#issuecomment-643782167, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFUY3GTGWS55WIH3JM7ZQQTRWTUGHANCNFSM4N3YNTIQ .