search

saurabhdaware / text-to-handwriting

So your teacher asked you to upload written assignments? Hate writing assigments? This tool will help you convert your text to handwriting xD
https://saurabhdaware.github.io/text-to-handwriting/
MIT License
4.71k stars 1.13k forks source link

Dark Mode Please? #50

Closed ForceGT closed 4 years ago

ForceGT commented 4 years ago

Is your feature request related to a problem? Please describe. My eyes are burning xD

Describe the solution you'd like A well developed dark mode with #000 and not #999

saurabhdaware commented 4 years ago

Haha is it really needed though? The tool will be used for a limited time right? it makes sense to have a dark mode for something like Twitter or Instagram which you use constantly and can spend hours scrolling through the feed.

Would like to know thoughts on this

ForceGT commented 4 years ago

You know dark mode is really soothing to the eyes And going by what you said it's needed for apps like Twitter or Instagram where user retention is high, for this tool you made, a user will spend roughly between 10 min to 30 min typing (You know if you see engineering assignments are atleast 10 pages long) so I think that should be a good enough reason to think upon adding dark mode

ForceGT commented 4 years ago

Besides I know you're really pro and I shouldn't be telling you how to do what All I can think of darkmode isDarkMode.js with a small input element anywhere of type checkbox and some css

saurabhdaware commented 4 years ago

Yes makes sense, I'll keep this open if anyone wants to work on this.

Besides I know you're really pro and I shouldn't be telling you how to do what All I can think of darkmode isDarkMode.js with a small input element anywhere of type checkbox and some css

You can definitely suggest ways to do it, this is the whole point of open-source :D

Maybe we can have CSS variables and define colors This is what I do in one of my projects,

body {
  --background-primary: #fff;
  --font-color-primary: #333;
  --elevation-background: #fff;
  --code-background: #f3f3f3;
  --link-color: #006EB8;
  --font-family-primary: 'Noto Sans KR', sans-serif;
}
body.dark {
  --background-primary: #121212;
  --font-color-primary: #ccc; 
  --elevation-background: #1D1D1D;
  --code-background: #222;
  --link-color: #09f;
}

an on toggle, I change the class of body

harshilparmar commented 4 years ago

@saurabhdaware Can I try this!!!

saurabhdaware commented 4 years ago

Sure! go ahead and let me know if you need any help :D